search

tokuhirom / Minilla

Authorizing tool for CPAN modules
https://metacpan.org/release/Minilla
Other
98 stars 65 forks source link

Ask Git for the top level, rather than inferring from .git/ #250

Closed mavit closed 6 years ago

mavit commented 6 years ago

This fixes an issue where minil would try to act on the parent module rather than the submodule when in the submodule’s directory.

When inside a Git submodule, .git is a file, not a directory. By asking Git itself for the top level, we don’t have to worry about such complications.

skaji commented 6 years ago

@mavit Could you explain why you develop CPAN distributions as git submodules?

karenetheridge commented 6 years ago

I'm not saying that this is the hill to stop fighting on, but I thought Minilla was intended to be a minimal package manager, i.e. handles the most common and non-strange cases.. and submodules sounds like something unusual.

mavit commented 6 years ago

I don’t, as such. I was looking for a straightforward way to install my application code along with its dependencies, and treating it as a CPAN module that never gets uploaded to CPAN seemed to be the way to do that.

If you think this is out of scope for Minilla, that’s fine, I won’t be offended.

skaji commented 6 years ago

I talked with tokuhirom, and he said "minil may support git-submodule". So I'll merge this PR.

@mavit Thanks for PR!