search

tokuhirom / Minilla

Authorizing tool for CPAN modules
https://metacpan.org/release/Minilla
Other
97 stars 65 forks source link

Versions are updated in not indexed files #256

Closed vti closed 5 years ago

vti commented 5 years ago

Inside of t/ directory I have a test file with our $VERSION = '123' inside. When trying to release with Minilla that version is updated too, even though t/ directory is in no_index list. I think that skipping unindexed would prevent this from happening and actually makes sense, since those file won't be indexed by CPAN anyway.

vti commented 5 years ago

Using # No BumpVersion helps, but it probably makes sense to ignore specific directories.

skaji commented 5 years ago

@vti Could you check #257 ?

vti commented 5 years ago

@skaji works!