search

tokuhirom / Minilla

Authorizing tool for CPAN modules
https://metacpan.org/release/Minilla
Other
97 stars 65 forks source link

{{$NEXT}}: support CRLF #260

Closed cxw42 closed 4 years ago

cxw42 commented 5 years ago

Thank you for this tool! I would like to propose the following patch to the verification of the Changes file when you run minil release: permit \r\n (instead of just \n) after the {{$NEXT}} tag. This fixes #259. This change will make it easier to use Minilla with Windows-based projects. Thank you for considering this request!

karenetheridge commented 5 years ago

I think you can achieve the first point by simply changing \n in regular expressions to \R. It might be good to separate that from the other changes, that check for more things.

cxw42 commented 5 years ago

@karenetheridge Thanks for the suggestion! I see \R (and \h) are in 5.10.0, which Minilla requires. I have updated this PR and will open a new one with the other changes.

syohex commented 4 years ago

Close by #264