Open cxw42 opened 5 years ago
set release_status to testing if --trial is given
I agree. We should set release_status testing.
support --trial on minil build and minil dist
I don't think so. Minilla sets release_status unstable intentionally if it is in a git repository.
@skaji Thank you for your comment!
Minilla sets release_status unstable intentionally if it is in a git repository.
That makes sense. However, I am confused. On my system, I do not see this behaviour. See, e.g., https://github.com/tokuhirom/Minilla/blob/v3.1.4/lib/Minilla/Project.pm#L420 - release_status
is set for underscore versions, but I do not see a test for being in a git repository.
I see the following:
$ minil new Acme-Foo
$ cd Acme-Foo
$ git remote add upstream https://cxw42@github.com/cxw42/Acme-Foo.git
$ minil build
$ grep release_status Acme-Foo*/*
Acme-Foo-0.01/META.json: "release_status" : "stable",
Acme-Foo-0.01/MYMETA.json: "release_status" : "stable",
Would you be willing to try this, or let me know what I'm missing? Much appreciated!
minil release
supports the--trial
option that changes the tgz filename. However, it still shows therelease_status
asstable
(unless I'm doing something wrong; see example). For consistency, would you be willing to make two changes?release_status
totesting
if--trial
is given--trial
onminil build
andminil dist
That way I could see the full code to be released using
build
ordist
before actually runningrelease
. Please let me know your thoughts. Thank you!