tokuhirom / Minilla

Authorizing tool for CPAN modules
https://metacpan.org/release/Minilla
Other
97 stars 65 forks source link

Take author name from AUTHOR section even if it appears later. #302

Closed kaz-utashiro closed 3 years ago

kaz-utashiro commented 3 years ago

Currently, the author's name is taken from the LICENSE section if it appears earlier than the AUTHOR section. I believe it is not intentional behavior. This code makes it always look at the AUTHOR section if it exists. I added minimal updates in other regex parts.

syohex commented 3 years ago

Could you add some unit tests ?

kaz-utashiro commented 3 years ago

I'll try, but I can't promise when.

kaz-utashiro commented 3 years ago

I updated the existing code to test just the patch works. I'm not sure you like it...

kaz-utashiro commented 3 years ago

Thanks for your acceptance. I disregarded in this patch, but I don't understand what /\d\d\d[\d.]+/ want to match in copyright notice. Maybe /\d\d\d[\d-]+/ is what they want.