search

tokuhirom / Minilla

Authorizing tool for CPAN modules
https://metacpan.org/release/Minilla
Other
97 stars 65 forks source link

Check release branch #305

Closed kfly8 closed 3 years ago

kfly8 commented 3 years ago

If release.branch is set, check if the current branch matches that release branch. We can use release.hooks to check if the release branch is correct, but it's better to notice mistakes before editing Changes.

skaji commented 3 years ago

Can you add document of release.branch to https://github.com/tokuhirom/Minilla#configuration too?

kfly8 commented 3 years ago

@skaji Thanks for the review. I added document of release.branch: https://github.com/tokuhirom/Minilla/pull/305/commits/81dd9a1354f34eb1eba3ccdfc907245d4f371a8b

skaji commented 3 years ago

According to https://stackoverflow.com/questions/6245570/how-to-get-the-current-branch-name-in-git, git branch --show-current is only available on git 2.22+. I think we should use git rev-parse --abbrev-ref HEAD instead.

kfly8 commented 3 years ago

Thanks a lot! Fixed it.