tokuhirom / Minilla

Authorizing tool for CPAN modules
https://metacpan.org/release/Minilla
Other
98 stars 65 forks source link

use just "prove" in github actions template #319

Closed skaji closed 2 years ago

skaji commented 2 years ago

Minilla defaults to create distributions with Module::Build::Tiny's Build.PL. While Minilla correctly adds Module::Build::Tiny as a configure dependency to META.json, if we manually execute Build.PL, we need to install Module::Build::Tiny first.

Let's simply use prove in github actions template.

syohex commented 2 years ago

Code looks good.

I have a question. If the module is XS module, then users have to rewrite github actions yaml ?

skaji commented 2 years ago

I have a question. If the module is XS module, then users have to rewrite github actions yaml ?

Yeah. Should we take care of it?

syohex commented 2 years ago

Yeah. Should we take care of it?

I think no we shouldn't. Because most people write pure perl module and only few people write XS module.

skaji commented 2 years ago

@syohex Thanks for your review. I'm going to merge this PR.

P.S. If someone wants to extend the github actions template for XS, patches welcome.