search

tokuhirom / Minilla

Authorizing tool for CPAN modules
https://metacpan.org/release/Minilla
Other
97 stars 65 forks source link

release fails on submodule #322

Closed kaz-utashiro closed 1 year ago

kaz-utashiro commented 1 year ago

minil release fails when runs on submodule directory, because .git/HEAD file does not exist.

readline() on closed filehandle $fh at /Users/utashiro/perl5/lib/perl5/Minilla/Release/Commit.pm line 44.
Use of uninitialized value $head in scalar chomp at /Users/utashiro/perl5/lib/perl5/Minilla/Release/Commit.pm line 44.
Use of uninitialized value $head in pattern match (m//) at /Users/utashiro/perl5/lib/perl5/Minilla/Release/Commit.pm line 47.

Path for HEAD file can be got by git rev-parse --git-path HEAD. I guess reverting https://github.com/tokuhirom/Minilla/commit/1044870 is also possible solution, if no one is using older version.

gregoa commented 1 year ago

Minilla also fails its test suite with git 2.38.1, cf. https://bugs.debian.org/1023422

gregoa commented 1 year ago

Preliminary patch at https://salsa.debian.org/perl-team/modules/packages/minilla/-/blob/master/debian/patches/git-2.38.1.patch (inspired by https://github.com/book/Git-Repository/pull/22 and https://vielmetti.typepad.com/logbook/2022/10/git-security-fixes-lead-to-fatal-transport-file-not-allowed-error-in-ci-systems-cve-2022-39253.html), feedback welcome.

syohex commented 1 year ago

v3.1.20 was released. Please check it

gregoa commented 1 year ago

With 3.1.20 the tests pass again, thanks!