search

tokuhirom / Test-Pretty

Other
20 stars 17 forks source link

Revamp subtests to use Test::Builder::subtest while remaining pretty #24

Closed lejeunerenard closed 9 years ago

lejeunerenard commented 10 years ago

Solved #21

Decided to overwrite Test::Builder::note instead of writing our own subtest() without Test::Builder's planning features.

Also made a design decision to include not oks for subtests but not oks.

Note:

  1. skip_all in subtests isn't pretty. It probably should be restyled.
  2. not oks from subtests are output at the same indent as other tests of the same level. Maybe this should be half indented like the subtest's name?
lejeunerenard commented 10 years ago

Also unintentionally fixed #16 since it now returns Test::Builder's original subtest value.

Tried @osfameron code and # Success wasn't printed.