search

tokuhirom / plenv

Perl binary manager
Other
512 stars 70 forks source link

Tiny fix of regexp for completions' comments #136

Open krautcat opened 6 years ago

krautcat commented 6 years ago

This fix allows to have comments with provide plenv completions not only as standalone strings but also for embedded inline comments. Also, the commit fixes completions for plenv commands command and other possibly broken before commands.

krautcat commented 6 years ago

@tokuhirom, any updates here?

syohex commented 4 years ago

I don't understand why this change is necessary ? (Note: rbenv does not accept this syntax). Could you show us any use-case ?

I suppose it is enough to add standalone comment like #provide plenv completions

krautcat commented 4 years ago

Basically it's just comment and it could be anywhere in the string.

For example, libexec/plenv-commands has following strings:

case "$1" in
--complete ) # Provide plenv completions
  echo --sh
syohex commented 4 years ago

I suppose we should fix that file and should not fix magic comment rule regexp