search

tokyo-night / tokyo-night-vscode-theme

A clean, dark Visual Studio Code theme that celebrates the lights of Downtown Tokyo at night.
MIT License
1.74k stars 119 forks source link

Scrollbar color #58

Closed mapsgeek closed 2 years ago

mapsgeek commented 2 years ago

Scrollbar color is missed up for themes altsynt and gogh but fine for the just night and night storm. tried uninstalling/reinstalling, different versions! it didn't use to look like that.

image image

enkia commented 2 years ago

Do you have anything with editorOverviewRuler.background in your settings.json?

mapsgeek commented 2 years ago

@enkia nope, should i add it under colorCustomizations ? isn't supposed to be provided by the theme?

enkia commented 2 years ago

You could try that but it shouldn't be necessary. Vscode uses the editor.background color if the editorOverviewRuler.background color isn't specified and only if you have minimal enabled which you don't.

I'm not sure what is causing the issue, but this is the first issue referencing it so I doubt it's my theme. Many themes don't specify the color either such as OneDark-Pro, Night Owl, etc. I also notice that the latest release of vscode added a shell integration feature to the overview ruler area so it may have something to do with that.

mapsgeek commented 2 years ago

hmm not really sure, all other themes are just fine and this happens only with the mentioned themes. so i just added an overwrite to my used theme, I just needed to know the name of the property

"[Tokyo Storm AltSynt]": {
      "editorOverviewRuler.background": "#24283B",
      "editorOverviewRuler.border": "#141a3a"
    }
enkia commented 2 years ago

"Tokyo Storm AltSynt" isn't my theme.

mapsgeek commented 2 years ago

ok sorry thought that it's the same theme.