Update menu and menubar selection background to improve contrast

tokyo-night / tokyo-night-vscode-theme

A clean, dark Visual Studio Code theme that celebrates the lights of Downtown Tokyo at night.

MIT License

1.8k stars 119 forks source link

Update menu and menubar selection background to improve contrast #6

Closed rychkog closed 4 years ago

rychkog commented 4 years ago

Hello @enkia! Thank you for the wonderful theme - I enjoy it :)

Have a suggestion regarding a color that makes menu items not visible in the "Tokyo Night Light" variation.

Here is what I have with the current implementation:

And another one

Here is the color I suggest (though any color of your choice with proper contrast will fit)

enkia commented 4 years ago

Thanks for the contribution! I'm at a bit of a disadvantage when viewing the theme on windows as I use a Mac. I really should install a windows virtualbox or something...

rychkog commented 4 years ago

I'm actually a Linux user, so those screenshots are from there :) I Will be keeping an eye on rendering artifacts at least on my platform and let you know in case of any.

enkia commented 4 years ago

Much appreciated, @rychkog