search

tokyo-night / tokyo-night-vscode-theme

A clean, dark Visual Studio Code theme that celebrates the lights of Downtown Tokyo at night.
MIT License
1.74k stars 119 forks source link

Highlight background color too subtle #69

Closed samholmes closed 1 year ago

samholmes commented 1 year ago
Screen Shot 2023-03-02 at 1 34 10 PM Screen Shot 2023-03-02 at 1 34 20 PM

I've highlighted the word "hello" in the second image, but the highlight is too faint to notice. Why is this happening?

samholmes commented 1 year ago

I fixed it with this:

  "workbench.colorCustomizations": {
    "editor.selectionBackground": "#135564",
    "editor.selectionHighlightBackground": "#135564",
    "terminal.selectionBackground": "#135564"
  },
Screen Shot 2023-03-02 at 1 36 47 PM

Shouldn't this be committed upstream? (preferably with a color from the theme's palette)

enkia commented 1 year ago

I've increased it slightly since this issue has come up in the past. However, based on your screenshots, you might decide your settings are preferable.

samholmes commented 1 year ago

I've increased it slightly since this issue has come up in the past. However, based on your screenshots, you might decide your settings are preferable.

What does it look like?

enkia commented 1 year ago
image image