search

tokyo-night / tokyo-night-vscode-theme

A clean, dark Visual Studio Code theme that celebrates the lights of Downtown Tokyo at night.
MIT License
1.74k stars 119 forks source link

feat: adding jsdoc-style settings in readme #79

Closed tigga73 closed 11 months ago

tigga73 commented 11 months ago

Til now the JSDoc it's seems like a normal comment. With this PR the JSDoc will have highlights.

lucasnneto commented 11 months ago

I tested it and found the change very nice. Looking forward to this implementation arriving

tigga73 commented 11 months ago

Before: image

After: image

enkia commented 11 months ago

For me this is a pretty drastic change. I definitely get why it would be useful, but I prefer jsdocs the way they are now and the theme is more of a personal theme that I was told others might like so I published it, heh. I feel that this would be better placed as one of the settings mentioned in the README?

tigga73 commented 11 months ago

I revert the changes in the theme file, and added the settings to highlight jsdoc in REDME. that's ok?

enkia commented 11 months ago

Thanks, so many will appreciate this!