search

toland / patron

Ruby HTTP client based on libcurl
http://toland.github.com/patron/
MIT License
541 stars 73 forks source link

Fixing Charset Issues #135

Closed AlexRiedler closed 8 years ago

AlexRiedler commented 8 years ago

This is a little bit of fixes on #122 ; I am not sure if there is more work to be done. Would be willing to put in more effort to get this going.

AlexRiedler commented 8 years ago

I think there was also some talk about doing force utf-8 instead on body; if no charset provided; and use non-reencoded back function as well?

toland commented 8 years ago

@AlexRiedler Thanks for the contribution!

Everything looks reasonable to me, but I am going to defer to @julik.

julik commented 8 years ago

Good stuff @AlexRiedler I need to look into this in more detail because I remember I stalled in my original PR when I realised there was fundamentally no better way without doing stuff you do not expect. Hope I can find some time for this until Monday.

AlexRiedler commented 8 years ago

@julik just a friendly reminder; I know how busy it can get :)

julik commented 8 years ago

Thanks for the reminder @AlexRiedler been crazy busy. Looks good to me, I think we need to see how this will influence stuff in production. Also since Patron is (at this point) below 1.0 we are still under the semver threshold of having no breaking changes, so I'm putting this through and we'll see where we end up. ❤️