search

toland / qlmarkdown

QuickLook generator for Markdown files.
3.24k stars 141 forks source link

Update Homebrew now that 'cask' is deprecated #105

Open alanhogan opened 2 years ago

alanhogan commented 2 years ago

See https://brew.sh/2020/12/01/homebrew-2.6.0/

tl;dr 'cask' should be removed from installation commands.

vidhill commented 2 years ago

Should it be brew install qlmarkdown --cask ?

sekizou82 commented 2 years ago

https://github.com/Homebrew/homebrew-cask/pull/114520 qlmarkdown has been renamed to toland-qlmarkdown, so it should be brew install toland-qlmarkdown --cask.

alanhogan commented 2 years ago

@vidhill the --cask flag doesn’t seem to be necessary.

vidhill commented 2 years ago

I was getting mixed up, there are two repos/projects, https://github.com/toland/qlmarkdown and this,

When someone runs brew cask install qlmarkdown it installs https://github.com/sbarex/QLMarkdown version?

alanhogan commented 2 years ago

When someone runs brew cask install qlmarkdown it installs https://github.com/sbarex/QLMarkdown version?

Without researching it, I am not sure what version brew install qlmarkdown installs, but brew cask install qlmarkdown will not install anything. It gives this error:

Error: `brew cask` is no longer a `brew` command. Use `brew <command> --cask` instead.

sekizou82 commented 2 years ago

When I ran brew install qlmarkdown --cask, it installed https://github.com/sbarex/QLMarkdown.

alanhogan commented 2 years ago

Interesting… Hmm. Well, the REAMEs over there do have the updated brew syntax, so that’s good.