search

toland / qlmarkdown

QuickLook generator for Markdown files.
3.25k stars 142 forks source link

Update the render after each file modification #55

Open nrichards opened 9 years ago

nrichards commented 9 years ago

First, thanks for the neat plugin!

Currently the plugin renders a .md file and up to one modification of that .md file. After watching the render window for five minutes, no more re-rendering occurs. Any file-modifications (like if I edit the .md file) are not propagated to the QuickLook window.

I desire for the QuickLook window to refresh upon each change (forward in time, backwards in time) to the file modification date.

OSX 10.10.5. QLMarkdown version:

~/frameworks/qlmarkdown (master)$ brew cask info qlmarkdown
qlmarkdown: 1.3.3
QLMarkdown
https://github.com/toland/qlmarkdown
/opt/homebrew-cask/Caskroom/qlmarkdown/1.3.3 (9 files, 196K)
https://github.com/caskroom/homebrew-cask/blob/master/Casks/qlmarkdown.rb
==> Contents
  QLMarkdown.qlgenerator (qlplugin)

Q: Is this something handled by the plugin or by QuickLook framework itself?

nrichards commented 9 years ago

Update: it (QuickLook itself?) appears to refresh the render after a few more minutes than I'd previously tested. Digging around for detail on changing this update frequency.

nrichards commented 9 years ago

Update 2: fascinating, the thumbnail is updated frequently. The window-sized preview is not.

tarwich commented 9 years ago

I think the problem might be that we're not calling the latest render API calls. I'm planning on rewriting that soon, so it shouldn't be a problem. Problem is my free time is tied up until 10 Oct, so it's going to be hard.

This plugin was written for an older version of OSX. The reason that I took the survey (#52) was so that I could know if I could ditch support for old systems and just support the more modern ones. Seems that's the case, which will make it easier.

nrichards commented 9 years ago

That makes total sense. Thank you for your continued support @tarwich.

A workaround for me is to ramp up the thumbnail size to nearly it's maximum and base my editing off that.

Issues I've noticed which might be resolved by an upgrade are that the thumbnails when 100% maximized stop rendering, and in Cover Flow mode thumbnails do not appear.

If this issue is a dupe of your planned rewrite (associated with #52) then I guess we can close this.