search

toleda / audio_CloverALC

macOS Realtek ALC onboard audio with Clover
680 stars 109 forks source link

Variables missing quote marks and other trivia #30

Open rammjet opened 9 years ago

rammjet commented 9 years ago

In script v1.0.4d, there are a few variables that need to be placed in quotes to control spaces in names. The variable "$gCloverDirectory" needs quotes because the directory name may have spaces. This happened in my case.

Also, unfortunately, the script could not detect my ALC892 codec and would shutdown. I had to modify the script to set the codec so it would pass the test and not shutdown.

Lastly, I have a legacy setup with 2 partitions. The EFI folder is on the 1st partition. But I was running the script on the 2nd partition and the script could not find EFI. There was no EFI on the booted 2nd partition because it was controlled by the EFI on the 1st partition. Had to put a temp copy of the EFI folder onto the 2nd partition and after patching, move it to the 1st partition.

toleda commented 9 years ago

Thanks for the suggestions and feedback.

  1. "$gCloverDirectory" to be added to next version.
  2. OS X sees the codec with a completely native install. No codec is not a script problem.
  3. Impossible to consider all non normal configurations. Your solution is appopriate for your configuration.