search

tolgaatam / ColabTurtle

An HTML based Turtle implementation, in order to work in Google Colab
MIT License
54 stars 30 forks source link

Accepting pull requests? #14

Open AllenDowney opened 6 months ago

AllenDowney commented 6 months ago

Thank you for making this available! For the third edition of Think Python, I was looking for a turtle graphics module that would work with both Colab and Jupyter Book, and your module was the best fit.

I ended up making a modified version that I distribute along with the notebooks for the book. You can see the modified version here:

https://github.com/AllenDowney/ThinkPython/blob/v3/Turtle.py

Mostly I added functions and aliases to provide a simple API that I could explain early in the book. I don't think I broke any existing features, but I would have to check.

If I put together a pull request that contains my changes -- and check that I'm not breaking anything -- would you be interested in merging? Or would you prefer if I keep my modified version separate?

tolgaatam commented 3 months ago

Hi Allen, thanks for using ColabTurtle and improving/extending it. I was definitely not having the best months of my life, and I missed this issue submitted by you. Deeply sorry for that 🙏

I would be more than happy if you opened a pull request. We can carry on with the conversation there. We can do a full merge if nothing breaks, or cherry-pick if there are any breaking changes. I am open to discussion.

AllenDowney commented 3 months ago

No problem, I hope things are better now!

Starting from your project, Luciano Ramalho has done a rewrite from scratch, which you can see here:

https://github.com/ramalho/jupyturtle

It has a similar API and also generates SVG, but it has turned into a different project, so probably doesn't make sense any more to merge them. But thank you for the inspiration!