tolgee / tolgee-cli

The Tolgee CLI
MIT License
16 stars 11 forks source link

Pull command creates json files with an additional space on each line #62

Closed baptisteArno closed 11 months ago

baptisteArno commented 11 months ago

Currently, when executing a pull command, it generates JSON files that looks like this:

{
  "account.apiTokens.createButton.label" : "Erstellen"
}

IMO, It would be preferable to remove the space between the key and the column symbol:

{
  "account.apiTokens.createButton.label": "Erstellen"
}
cyyynthia commented 11 months ago

The CLI doesn't process the files and dumps whatever it received from the Tolgee server; I believe that's something outside of the CLI scope here 😅

baptisteArno commented 11 months ago

Ok I see, thank you for the clarification

allenhehe commented 1 month ago

The CLI doesn't process the files and dumps whatever it received from the Tolgee server; I believe that's something outside of the CLI scope here 😅

So this mean the json file generated by Tolgee server is wrong? It shouldn't contain those spaces right?

JanCizmar commented 1 month ago

Hello. It's already fixed by this PR: https://github.com/tolgee/tolgee-platform/pull/2432

However, it is valid json generated by the common jackskon objectMapper it wasn't a big issue before

allenhehe commented 1 month ago

Hello. It's already fixed by this PR: tolgee/tolgee-platform#2432

However, it is valid json generated by the common jackskon objectMapper it wasn't a big issue before

I see, thank you!