search

tolgee / tolgee-cli

The Tolgee CLI
MIT License
16 stars 11 forks source link

Release 2.0.0 breaking change on --path parameter #81

Closed danton721 closed 4 months ago

danton721 commented 4 months ago

After running tolgee pull ./app --project-id 123 -v, I am receiving the following error

> tolgee pull ./public/i18n --project-id 123 -v
🔴 An unexpected error occurred while running the command.
🔴 Please report this to our issue tracker:
https://github.com/tolgee/tolgee-cli/issues
    at run (file:///[...]/node_modules/@tolgee/cli/dist/cli.js:144:9)

By looking at the specified file, the error is not being handled. I have added a console.log(e) to at least view the exception

image

And then the output was the following:

Error: Missing or option --path <path>
    at Command.<anonymous> (file:///[...]/node_modules/@tolgee/cli/dist/commands/pull.js:29:15)
    at Command.listener [as _actionHandler] ([...]\node_modules\@tolgee\cli\node_modules\commander\lib\command.js:542:17)
    at [...]\node_modules\@tolgee\cli\node_modules\commander\lib\command.js:1502:14
    at [...]\node_modules\@tolgee\cli\node_modules\commander\lib\command.js:1383:33
    at async Command.parseAsync ([...]\node_modules\@tolgee\cli\node_modules\commander\lib\command.js:1092:5)
    at async run (file:///[...]/node_modules/@tolgee/cli/dist/cli.js:136:9)
🔴 An unexpected error occurred while running the command.
🔴 Please report this to our issue tracker: https://github.com/tolgee/tolgee-cli/issues
    at run (file:///[...]/node_modules/@tolgee/cli/dist/cli.js:145:9)

~This command --path is not yet specified in the documentation, but checking on the code I could understand that we now need to call the CLI as tolgee pull --path ./public/i18n --project-id 123~

Command --path is specified on the documentation for the pull command only, but not in the overview of options. Furthermore, the command conflicts with the short for project id.

I'd recommend making the error clearer since it is an update on breaking-change.