search

tolgee / tolgee-cli

The Tolgee CLI
MIT License
15 stars 11 forks source link

feat: New sync option "default namespace" #87

Closed AgentOren closed 2 months ago

AgentOren commented 3 months ago

Re-make of #77 for v2.0 - but this time, only the "default namespace" part. My use case: monorepo where each subfolder project has its unique Tolgee namespace - which is difficult for the CLI to auto-detect.

stepan662 commented 3 months ago

Hey, thanks for this contribution 👍 Could you add some tests?

Also this would be an ideal candidate to have in tolgee config as well.

You can add it to schema.json and then run npm run config:type, which will add type definition as well.

AgentOren commented 3 months ago

Hey, thanks for this contribution 👍 Could you add some tests?

You welcome! Unfortunately, I don't have the time resources for this now. Can you point me to a similar test for example? I will take a look when I have some spare time.

Also this would be an ideal candidate to have in tolgee config as well. You can add it to schema.json and then run npm run config:type, which will add type definition as well.

As I understand (correct me if I'm wrong), the sync command is not part of the tolgee config (unlike the push and pull commands). Does it mean that the sync command is closed to new contributions until someone puts efforts to make it a first-class citizen like push and pull? We're talking about major work and breaking changes, similar to those made from 1.x to 2.x.

stepan662 commented 3 months ago

I'd say this might be considered part of the extractor, so it should be a general option (not part of any command, but global).

Test can be added here https://github.com/tolgee/tolgee-cli/blob/main/src/test/e2e/extract.test.ts

If you don't have time, it's fine. I'm actually currently re-writing the extractors to be more managable, so I can add this feature as a part of it (https://github.com/tolgee/tolgee-cli/pull/88).