search

tolgee / tolgee-cli

The Tolgee CLI
MIT License
15 stars 11 forks source link

pull delimiter=null still has structure #89

Closed wfjsw closed 2 months ago

wfjsw commented 2 months ago

Tolgee CLI 2.0.3 + Tolgee Platform 3.64.8. Seems to be a regression of #57

Config: 

$schema: "https://tolgee.io/cli-schema.json"
projectId: 20
delimiter: null
format: JSON_TOLGEE
push: 
  files:
    - path: "./StableDiffusionWebUILauncher/Localizations/Bundled/zh-Hans.json"
      language: "zh-Hans"
      forceMode: OVERRIDE
      convertPlaceholdersToIcu: true
pull:
  path: "./StableDiffusionWebUILauncher/Localizations/Bundled"
  state: 
    - REVIEWED
  emptyDir: false

image

stepan662 commented 2 months ago

Yes, seems like the whole delimiter option was somehow broken and there was no test for it, so I've added one and it should be fixed in the PR.

wfjsw commented 2 months ago

I can reproduce this issue still with above settings

image

Even if I change delimiter to ''

image

However it is gone if I use -d ''

image

cyyynthia commented 2 months ago

It appears delimiter is documented as a global property but this is a mistake. In CLIv2 it's pull.delimiter, so your yaml should look something like this:

pull:
  delimiter: null
stepan662 commented 2 months ago

Ah, I'll fix it in the docs.

stepan662 commented 2 months ago

https://github.com/tolgee/documentation/pull/615