fix: i18next update with addResourceBundle

tolgee / tolgee-js

Tolgee JavaScript libraries monorepo

https://tolgee.io

MIT License

218 stars 24 forks source link

fix: i18next update with addResourceBundle #3304

Closed perebusquets closed 3 months ago

perebusquets commented 3 months ago

PR to solve some translations missing in i18next-tolgee adapter. More details in the following issue: https://github.com/tolgee/tolgee-js/issues/3305

stepan662 commented 3 months ago

Hey, thanks for the PR, could you check the tests and eslint? I vaguely remember that this was not so simple and the test suggests that it's somehow not being overriten. The pipelines in PRs from forks don't work fully, but you should be able to run jest tests locally.

perebusquets commented 3 months ago

Hi! Sure, some of the tests failed due to the static translations (since I removed the resource check by mistake), by keeping the check everything seems to work like a charm

stepan662 commented 3 months ago

Ok, cool everything is working. Thanks for the PR ❤️