tolgee / tolgee-platform

Developer & translator friendly web-based localization platform
https://tolgee.io
Other
1.43k stars 115 forks source link

Modifying a `REVIEWED`🟢 translation should **automatically** update its state back to `TRANSLATED`🟡 #2408

Open calfzhou opened 2 months ago

calfzhou commented 2 months ago

Describe the bug

As mentioned in #1147, modifying a base translation will change other language strings' states back to TRANSLATED, and also set a OUTDATED indicator. Which is a great feature.

But I find that, when modifying a REVIEWED🟢 translation (not the base string), its state will not be changed back to TRANSLATED🟡.

To Reproduce

Steps to reproduce the behavior:

Assume that the base language is English, and the second language is German.

  1. Creates a key hello_world, set English string to "Hello World!", and German string to "Hallo Welt!".

  2. Marks the two strings as REVIEWED🟢.

    image
  3. Changes the German string to "Hallo Universum!".

    image image
  4. The modified German string is still in REVIEWED🟢 state.

Expected behavior

In the 4th step, after saving the new translation text in German string, its state should be automatically changed to TRANSLATED🟡. Then any reviewer could acknowledge the modification, and then review the modified string.

image

Screenshots

Attached in reproduce steps.

Versions and environment

Additional context

N/A

JanCizmar commented 1 month ago

Hey! Thanks for reporting. We need to check if this is the standard behaviour in other platforms. We never acutally plan it to work this way, but it makes sense, indeed. 🤔

DiscowZombie commented 1 month ago

Vouch, the review feature is totally useless with the current behavior