search

tolitius / boot-check

check, analyze and inspect Clojure/Script code
Eclipse Public License 1.0
70 stars 9 forks source link

Updated README.md. By default You need to require additional namespace - tolitius.reporter.html #18

Closed voytech closed 6 years ago

voytech commented 6 years ago

@tolitius And yet - there was an issue when generating reports (I think it is only on windows machine). I was clearing temp directory every time before adding items into it. While writing reports - it expected warning interim file to be present (in fact it doesn't use this file at this time - but it must be related to specific filesystem management operation on windows - as it expected file with issues to be present while iterating tmpdir before writing final html report file).

@tolitius I do not know how You would like to incorporate this fix? is it required to up the version? or You can make it in-place with current version.

tolitius commented 6 years ago

versions are not sacred, if the world's Clojure standard allow it (like it is allowed in Golang) I would only use commit hash for versioning, since 1.2.3 means nothing, and ce3a92c tells you exactly what/where and when it is.

I'll bump the version.