search

tolitius / boot-check

check, analyze and inspect Clojure/Script code
Eclipse Public License 1.0
70 stars 9 forks source link

Add options to throw exceptions or expose problems found as Clojure data structures #6

Closed eigenhombre closed 7 years ago

eigenhombre commented 7 years ago

My team would like to fail our builds depending on linting output, which is impossible to do without parsing the output from the linting tasks (yagni, bikeshed, etc).

It would be helpful to allow the option to raise an exception or, perhaps better yet, expose the problems found as Clojure data structures so that a wrapper task could fail drastically when problems occur.

As it is we are having to dissect and reimplement portions of the library to get the desired behavior (or parse the output as strings).

tolitius commented 7 years ago

The problem is some of the projects.

For example Bikeshed, does not return anything besides true or false. That is true for its internal tasks as well.

For Eastwood, it does not return actuals but rather the counters, etc..

I added the --throw-on-errors on every task. It is in 0.1.4-SNAPSHOT. Check out the handling errors docs.

Let me know if it works for you.

eigenhombre commented 7 years ago

Thanks! Next time I'm getting my hands dirty with this I can try it out. Seems close-able for now, but will let you close the issue. Thanks again for the quick response.

tolitius commented 7 years ago

closing this. feel free to reopen if you have more questions.