search

tolitius / boot-check

check, analyze and inspect Clojure/Script code
Eclipse Public License 1.0
70 stars 9 forks source link

Configure checkers through tasks #7

Closed AdamFrey closed 7 years ago

AdamFrey commented 7 years ago

Just wondering if you had a plan to pass arguments from the boot tasks down to the checkers themselves (like excluded namespaces, excluded linters, etc.).

Would you accept a PR that implemented some subset of argument passing or would you like to cover everything at once?

snorremd commented 7 years ago

Would like to see that as well. The default 80 character limit of Bikeshed is overly strict so would be very nice if I could pass the --max-line-length argument down via the check-with-bikeshed task.

tolitius commented 7 years ago

would -o + map not work for you?

i.e.

$ boot check/with-bikeshed -o "{:max-line-length 42}"

Checking for lines longer than 42 characters.
Badly formatted files:
## ....
tolitius commented 7 years ago

@AdamFrey which options are you looking to add? Some options are already supported via -o / --options, and bikeshed: https://github.com/tolitius/boot-check#bikeshed-options.

snorremd commented 7 years ago

@tolitius I was not aware of that option, though reading the README.md now in hindsight makes it quite obvious. Today I learned, and so forth. Then I've got everything I need, thank you.

tolitius commented 7 years ago

closing this. feel free to reopen if there are more questions