search

tolitius / cbass

adding "simple" to HBase
Eclipse Public License 1.0
24 stars 11 forks source link

Why cbass jar contains all its dependencies? #21

Open viebel opened 3 years ago

viebel commented 3 years ago

I was surprised when I discover that cbass jar contains all its dependencies?

Is it on purpose? Could you explain the rationale behind it?

tolitius commented 3 years ago

cbass was created years ago, an I might have missed something

deps I see are:

  :dependencies [[org.clojure/clojure "1.10.1"]
                 [org.apache.hbase/hbase-shaded-client "1.4.8"]
                 [aesahaettr "0.1.2"]
                 [com.taoensso/nippy "2.15.3"]]

these are the ones cbass actually can't do without one improvement, "clojure" can be marked as "provided". is that what you are asking?

most of the libs I create have no deps. I don't remember the mindset when created cbass, but do tell if you see anything that can be improved

rmangi commented 3 years ago

IIRC it’s because the hbase distributed client libs contain conflicting jars

tolitius commented 3 years ago

@rmangi I remember you added ":aot all", but don't remember the reason :)

if it is because of conflicting jars, is it safe to remove by #22?

rmangi commented 3 years ago

It was because we wanted a shadow jar. I don’t use this anymore so no objections if it works.

rmangi commented 3 years ago

Just be sure to test it deployed... there was definitely a reason we had to do this.

tolitius commented 3 years ago

@rmangi just to clarify: are you saying we can't remove :aot :all?

rmangi commented 3 years ago

No I’m just saying it was a problem at one point. If it works for you guys now I have no objections.

On Apr 8, 2021, at 3:09 PM, Anatoly @.***> wrote:

 @rmangi just to clarify: are you saying we can't remove :aot :all?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

tolitius commented 3 years ago

got, thanks @rmangi