search

tolitius / cbass

adding "simple" to HBase
Eclipse Public License 1.0
24 stars 11 forks source link

Remove :aot :all from project.clj #22

Closed viebel closed 3 years ago

viebel commented 3 years ago

This PR addresses #21. Setting :aot :all in project.clj causes all the dependencies to be packaged as part of the jar that is uploaded to Clojars. This is very annoying for application using cbass that has dependencies in common with cbass or with a transitive dependency of cbass (e.g taoensso/encore). I don't think it's a good practice to package deps inside a lib.

tolitius commented 3 years ago

@viebel thanks for the pull request! can you test with your app (dev and as an uberjar) to make sure it works: i.e. you are able to call out to hbase find/create data?

conversation in #21 is the reason I am asking

viebel commented 3 years ago

I have tested positively with our app but our setting is unusual:

  1. We use Bigtable driver instead of hbase driver
  2. We don't use nippy.
rmangi commented 3 years ago

That’s probably not a good test.

On Apr 9, 2021, at 4:08 AM, Yehonathan Sharvit @.***> wrote:

 I have tested positively with our app but our setting is unusual:

We use Bigtable driver instead of hbase driver We don't use nippy. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.

viebel commented 3 years ago

Can somebody else test it in the regular setting?

viebel commented 3 years ago

Can somebody else test it in the regular setting so we could fix the artifact?

viebel commented 3 years ago

Can somebody else test it in the regular setting so we could fix the artifact? @tolitius

tolitius commented 3 years ago

unfortunately I don't have a setup at the moment to test this let's merge this, and, @rmangi, if when you, or someone else needs it again we'll revisit

viebel commented 3 years ago

Thanks.