Closed dm3 closed 6 years ago
Will have a look, busy busy now. Thanks for trying the port!
@dm3 how did you try :advanced
compilation? Using the new lumo
compiler?
@tolitius what is your take on this one?
changes look good. 3 things I am not sure about:
self-hosted Clojurescript
#?(:clj/s
places in .core
need deftime
?:advanced
vs. macro conflictI have not done anything with self hosted ClojureScript yet, and cljs :advanced
is not simple by any means, fussy, and takes a lot of handholding. All 3 could have simple answers of course.
I have tried to test with tach
but datascript
is not self-host compatible so it did not work.
About :advanced
, I have not idea why is that.
@dm3 total wild guess, have you tried to use straight macrovich or to have its macros in a separate namespace?
I don't have an explanation for that but I will actually this next
Also I am very confident in saying that you need the :require-macros
in mount.tools.macros
.
Again, I will try it in my branch and report back.
thanks for the work on this. it is now composed with #97
Continuing the #79: Mount now works under self-hosted Clojurescript - tested with Planck and Lumo. The changes were pretty minimal:
deftime
macro and put thedefstate
macros withindeftime
.I had some problems while trying to make it work, so several functions that didn't depend on state were moved before the state vars. Also the type constructors are now called via the
->
constructor functions.There's one remaining issue with the advanced mode compilation. It complains about
mount.tools.macro
:I have limited experience with Clojurescript/advanced mode so any help would be welcome.