search

tollmanz / wordpress-pecl-memcached-object-cache

A WordPress object cache that uses the memcached (not memcache) PECL extension.
233 stars 114 forks source link

Add server number awareness to *ByKey methods #8

Closed tollmanz closed 12 years ago

tollmanz commented 12 years ago

It appears that the *ByKey methods in Memcached are very arbitrary. It is hard to match a key to a server. The following changes are suggested:

1) In the event that there is a single server, route all *ByKey requests to a single $server_key for the runtime change. The getServerByKey method may need to be utilized to make this work correctly.

2) Will likely need to create an internal mapping of server keys and servers in order to keep runtime cache and memcache servers in sync.

tollmanz commented 12 years ago

Turns out that this addByKey and getByKey methods pass unit tests that consider what is in the runtime cache as well as what is actually stored in memcached. I will leave the ticket open for now as I continue to explore and test this issue.

tollmanz commented 12 years ago

Decided to remove the notion of notion of server keys in the internal cache (26116b18123f060dfe0723f012da8f60ee610ebd), which makes this moot.