Simple and lightweight implementation of the Apache Lucene Index as frontend search solution for TYPO3. Created by Joschi Kuphal (@jkphl), licensed under the terms of the GPL v2 license.
@cdfre First of all: Thanks a lot for all your contributions over the last two years! I FINALLY found the time to review and merge them — at least the majority of them.
There's one particular commit that I couldn accept as-is because I see several problems with it: # e2d8164
I'm not totally convinced that this the behaviour the user expects when a search would actually fail?!
You're skipping the search term rewrite hooks altogether
There's no error handling in your code (what happends if the index throws an exception?)
@cdfre First of all: Thanks a lot for all your contributions over the last two years! I FINALLY found the time to review and merge them — at least the majority of them.
There's one particular commit that I couldn accept as-is because I see several problems with it: # e2d8164
If you're up for it, please review this particular part of your code and send another PR — I'd happily review it again then!
Thanks again.