search

tollwerk / TYPO3-ext-tw_lucenesearch

Simple and lightweight implementation of the Apache Lucene Index as frontend search solution for TYPO3. Created by Joschi Kuphal (@jkphl), licensed under the terms of the GPL v2 license.
http://typo3.org/extensions/repository/view/tw_lucenesearch/
GNU General Public License v2.0
4 stars 3 forks source link

[FEATURE] Ajax Autocomplete #6

Closed IndyIndyIndy closed 10 years ago

IndyIndyIndy commented 10 years ago

fixes #5

jkphl commented 10 years ago

@IndyIndyIndy Wow, thanks a lot! Will have a look at this ASAP (probably tomorrow).

jkphl commented 10 years ago

@IndyIndyIndy Finally working on the search now — thanks for this awesome enhancement! Will review it further the next days, more features to come as well! :)

jkphl commented 10 years ago

@IndyIndyIndy I'm about revising your autocomplete addition, and I've got a couple of questions:

  1. What happens if someone enters two or more words into the search input (separated by whitespace). Is the whole entry to be treated as a phrase? At the moment, it is not ...
  2. The regular search supports some rewrite hooks for the search terms submitted. I would expect the autocomplete feature to yield the same results as the regular search, which would require to apply the rewrite hooks as well. Is there a reason why you didn't implement these hooks into the autocomplete search as well?
  3. Similar applies to the support for language and rootline based restrictions: The regular Lucene query is generated by the query() method, which is taking care of these restrictions. Any reason you didn't implement this? Which basically means, that you will also get autocomplete in other languages than the current, or from different page trees (in case you've got a multiple tree TYPO3 instance).

Thanks for your feedback!