Support Transactions API

toloco / pyoanda

Oanda’s API python wrapper. Robust and Fast API wrapper for your Forex bot Python library that wraps Oanda API. Built on top of requests, it’s easy to use and makes sense.

http://oanda.com

MIT License

66 stars 24 forks source link

Support Transactions API #17

Closed elyobo closed 9 years ago

elyobo commented 9 years ago

@toloco Note that some changes were made to reduce the duplication in call and call_stream by using a third method, __call_raw, to handle the common parts and return the response. Access to the response was required by the implementation of the request_transaction_history method, as it needs to access the response headers not the response body, but it seemed like a more DRY approach as well.

landscape-bot commented 9 years ago

Code quality remained the same when pulling 212c64a on elyobo:implement-transactions-api into 9eeb129 on toloco:master.

elyobo commented 9 years ago

Resolved merge conflicts resulting from updates to master.

toloco commented 9 years ago

Can you make this against develop branch instead? I can't do it myself...

landscape-bot commented 9 years ago

Repository health increased by 0.36% when pulling 393c402 on elyobo:implement-transactions-api into 4edaa78 on toloco:master.

No new problems were introduced.
1 problem was fixed (including 0 errors and 0 code smells).

elyobo commented 9 years ago

Replaced by PR #22