tolstoyevsky / mmb

Set of Dockerfiles and assets related to them for building Docker images with different services
Apache License 2.0
39 stars 13 forks source link

hubot-rocketchat: doesn't work hubot extension named "hubot-reaction" #152

Open ya7on opened 5 years ago

ya7on commented 5 years ago

Description: Hubot extension named "hubot-reaction" that is contained in default value of EXTERNAL_SCRIPTS doesn't work in production. Here is deafult value of EXTERNAL_SCRIPTS: https://github.com/tolstoyevsky/mmb/blob/f9c4fd5d73fae055555152e2cc003ef67dd0d47a/hubot-rocketchat/docker-entrypoint.sh#L19 Bot shows command from this extension using hubot-help: image But when you use this command, bot doesn't respond.

Steps to reproduce:

  1. Run hubot-rocketchat with default value of EXTERNAL_SCRIPTS environment variable;
  2. Send command !reply tag to bot;
  3. Watch bot respond.

Expected result: Reaction image that is described in the README of this script.

Actual result: There is no respond.

Proposed solution: Remove this script from the default value of EXTERNAL_SCRIPTS.