search

toltec-astro / citlali

TolTEC data processing pipeline.
https://toltec-astro.github.io/citlali/
2 stars 0 forks source link

install instructions: missing boost dependency #7

Closed rguter closed 3 years ago

rguter commented 3 years ago

Not sure if this is universal, but in following the install instructions as written on my laptop (Pop_OS 20.04), I needed to install boost as a dependency (e.g. libboost-all-dev). Suggest adding it to the list of dependency packages to install for ubuntu 20.04 instructions, just in case it isn't present on a given system.

Jerry-Ma commented 3 years ago

Thanks for reporting. The boost dependency is something that we wanted to remove. I guess Michael @mmccrackan could chime in here and see how we can get rid of it.

In the meantime, I'll update the readme to include boost as one of the dependence until we fix it.

mmccrackan commented 3 years ago

I use the boost libraries in order to get the random numbers for the noise maps, as the random generator in Eigen is not thread-safe to my knowledge, so it would be good to keep at least boost::random in citlali.

Jerry-Ma commented 3 years ago

OK. I wanted to get rid of boost just because it seems to be too heavy (just my opinion). I did a bit searching and found this random generator that may also fit out need.

https://www.numbercrunch.de/trng/

mmccrackan commented 3 years ago

I'll see about adding that instead. I just remembered that I also use boost for the Bessel functions in the lowpass filter. I guess we could use gsl for that, though I imagine that gsl is about the same as boost in terms of scale.

Jerry-Ma commented 3 years ago

C++17 has some built in math function. I am not sure if the function we need is included: https://en.cppreference.com/w/cpp/numeric/special_functions

mmccrackan commented 3 years ago

I forget why I didn't use these before, as I know I looked at them, but I think these will work for our purposes. I'll go ahead and switch away from boost for both the random numbers and for the functions.