Open mmccrackan opened 5 years ago
Not on the list, but I separated the methods that gets the fit parameters for each detector and the method that actually makes the model Gaussian. This makes things that use these for all detectors run much faster.
Also, now that the weights are calculated differently, I set the weights that are nan (previously zero) to zero. This is mostly for plotting and any calculations and shouldn't affect anything else.
Finally, I removed references to the BoloData variable, which was used to get the number of detectors, since this is no longer being included in the beammaps. Number is currently hardcoded, but this will be fixed.
This is just a list of things I'm going to be either adding or improving in macana_plotter in the near future:
[ ] Remove duplicate code between methods (save option code for instance).
[ ] Make code structure/naming more consistent between methods.
[ ] Add/clean up comments, documentation, and output when code is run.
[ ] Improve user inputs for more understandability, consistency, and generalization.
[ ] Improve error handling/checking.
[ ] Fix chi-squared calculation in residual calculator.
[ ] Add option to make corner plot for particular sub-regions of the beam-map to resolve elevation 1D distribution issue (code exists, just needs to be implemented).
[ ] Add option to include fit information on corner plots (code exists, just needs adding).
[ ] Fix offset issue with corner plot.
[ ] Make region option more general (zoom with different lengths for each side).
[x] Make plots interactive, with ways to click on regions and get detector number and information (further in the future).
[ ] Add the ability to pass plotting params to the methods (color maps, line widths, etc).
Some other ideas: