Binary modification fills root partition until xochitl restart

[rM-self-serve]

Describe the issue

Modifying the binary via ddvk-hacks, #770, #772, or any future binary modification without restarting xochitl will lead to the system reporting the root partition as full.

This will result in failure if two binary modifications are applied sequentially as the second operation will detect the full root partition.

This is not apparent on v2.10 but is apparent on v2.15-v3.8.

In reference to https://github.com/toltec-dev/toltec/pull/772#issuecomment-1847916574

To Reproduce

Ensure xochitl is running as a service and is >= v2.15

df '/' | tail -n1 | awk '{print $4}'
cp /usr/bin/xochitl /tmp/
cp /tmp/xochitl /usr/bin/
df '/' | tail -n1 | awk '{print $4}'
systemctl restart xochitl
df '/' | tail -n1 | awk '{print $4}'

Expected behaviour

N/A

Upstream issue

N/A

Screenshots

[Eeems]

I think the solution we should implement for this is to move the modified version of xochitl to a location under /opt and use that instead. This may cause some conflicts with manual installation of binary hacks, but we already prefer that users don't do that and instead use the toltec packages. I'd be happy to open PRs in the various repositories to update their install/uninstall scripts to be aware of the new location.

[rM-self-serve]

I do wonder if https://github.com/toltec-dev/toltec/pull/720, https://github.com/toltec-dev/toltec/pull/770, and https://github.com/toltec-dev/toltec/pull/722 being reinstalled on reenable has the potential to cause other packages that may write to the root partition (something like a service file) to fail since the root partition is reported as full.

I have tested reinstall on reenable for all 3 packages and have not seen the issue but it may still be possible.

[Eeems]

I do wonder if #720, #770, and #722 being reinstalled on reenable has the potential to cause other packages that may write to the root partition (something like a service file) to fail since the root partition is reported as full.

I have tested reinstall on reenable for all 3 packages and have not seen the issue but it may still be possible.

Service files are quite small, so it's probably not likely to happen. Xochitl itself is rather large, so having it fail to overwrite due to the lack of enough space shouldn't actually fill the partition. Plus the patching happens as part of configure(), so I believe that all the files already exist on the root partition at this point, as configure should happen after all the package contents have been extracted.

Nevertheless, this should still be something we work on resolving before 3.x support, as the root partition filling up is just as pronounced in 3.x.