toltec-dev / toltec

Community-maintained repository of free software for the reMarkable tablet.
https://toltec-dev.org
MIT License
747 stars 60 forks source link

`move-logs-to-opt` fails to install if `var-log.mount` is masked #839

Open StachuDotNet opened 8 months ago

StachuDotNet commented 8 months ago

After downloading the .ipk artifact from this PR, and transferring it to my rM, I attempted to opkg install ./move-logs-to-opt.ipk, which failed

reMarkable: ~/ opkg install ./move-logs-to-opt_0.0.1-1_rmall.ipk
Package move-logs-to-opt (0.0.1-1) installed in root is up to date.
Configuring move-logs-to-opt.
Warning: Stopping systemd-journald.service, but it can still be activated by:
  systemd-journald.socket
  systemd-journald-dev-log.socket
Moving log files to new location
Failed to enable unit: Unit file /lib/systemd/system/var-log.mount is masked.
Collected errors:
 * pkg_run_script: package "move-logs-to-opt" postinst script returned status 1.
 * opkg_configure: move-logs-to-opt.postinst returned 1.

The core issue here seems to be Failed to enable unit: Unit file /lib/systemd/system/var-log.mount is masked..

I am running OS version 3.3.2.166 on my reMarkable 2.

I'm unsure why it was 'masked' -- this is a new concept to me.


I wasn't sure what to do here, so asked in Discord and someone suggested I run systemctl unmask var-log.mount and try again.

After doing so, I ran opkg remove move-logs-to-opt, attempted an install again, and all was well. (it seemed as though some install-related files hung around even for the above-failed installed)

Eeems commented 8 months ago

We don't want to add code to unmask something we aren't masking to a package, so we don't want to work around it that way. I'm surprised that the unit was masked though, as it doesn't appear to be masked in the 3.3.2 OS image, as it doesn't exist. Since this package is creating a brand new var-log.mount unit and starting it, this really shouldn't be happening.

Since we don't support 3.3.2 yet, this'll have to be on the backburner for now. It'll be something we need to test and ensure that it doesn't happen when we get 3.3.2 merged.