search

toltec-dev / toltec

Community-maintained repository of free software for the reMarkable tablet.
https://toltec-dev.org
MIT License
743 stars 60 forks source link

kernelctl should no longer use `/etc/version` #885

Closed Eeems closed 1 week ago

Eeems commented 4 months ago

Describe the issue Kernelctl uses /etc/version when creating a backup of the current kernel. As this stops being a unique value in newer OS builds,

To Reproduce Steps to reproduce the behaviour:

  1. install kernelctl
  2. run kernelctl list to see list of kernels

Expected behaviour It should be using RELEASE_VERSION from /usr/share/remarkable/update.conf for the OS version number instead.

Upstream issue N/A

Screenshots image

System information:

Additional context toltecctl has the following code available that kernelctl could call: https://github.com/toltec-dev/toltec/blob/eed41f1abede4150994186faa6a53612d90d88e0/package/toltec-bootstrap/toltecctl#L108-L110

Eeems commented 4 months ago

@Etn40ff would you be willing to make this change?

Etn40ff commented 4 months ago

@Etn40ff would you be willing to make this change?

Sure

Etn40ff commented 3 months ago

It only took me a month https://github.com/toltec-dev/toltec/pull/905