search

toltec-dev / toltec

Community-maintained repository of free software for the reMarkable tablet.
https://toltec-dev.org
MIT License
749 stars 60 forks source link

/opt/bin/xochitl script issues #908

Open Havner opened 2 months ago

Havner commented 2 months ago

Describe the issue 2 small issues in the script:

  1. The is-active function doesn't exist here https://github.com/toltec-dev/toltec/blob/stable/package/xochitl/xochitl#L24
  2. The script masks non existing service (e.g. rm-sync): https://github.com/toltec-dev/toltec/blob/stable/package/xochitl/xochitl#L20C1-L22C3 And nothing unmasks it when uninstalling as the unmask option have different conditions in the postremove: https://github.com/toltec-dev/toltec/blob/stable/package/xochitl/package#L110C1-L111C41

Not putting more info as this has been discussed in the discord and I think the code is clear enough to see the issues.