search

tolu / ISO8601-duration

Node/Js-module for parsing and making sense of ISO8601-durations
92 stars 10 forks source link

License #38

Open trew opened 1 month ago

trew commented 1 month ago

This repository does not contain a license file, meaning any tools checking for license compliance will fail on this library. I would recommend including a license file as part of the repository instead of linking to an external site.

tolu commented 1 month ago

the license is also listed in package.json, seems weird that that is not picked up by such tools. What specific tools are you referring to?

trew commented 1 month ago

The MIT license specifies:

The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.

That means it's not enough to just specify that MIT is used. The actual text needs to be provided. Most tools that I've seen look for a file in the distributed package called "LICENSE", "LICENSE.md" or "LICENSE.txt".

Me specifically are using https://www.npmjs.com/package/license-checker in combination with custom tooling to resolve the license texts for distribution, but license-checker resolves the licenseFile field to "README.md", which doesn't contain the license text.