search

toluschr / BetterDiscord-Animated-Status

Animate your Discord Status with this BetterDiscord Plugin
MIT License
255 stars 489 forks source link

Update README.md #38

Closed pintoso closed 3 years ago

pintoso commented 3 years ago

4

toluschr commented 3 years ago

Thanks. Are you ok with what I changed?

pintoso commented 3 years ago

Looks good, but 2900ms(2.9 seconds) this value is currently irrelevant, the minimum value now for the animation to flow and no request to be ignored is 10000ms(10 seconds)... so I recommend removing about 2.9 seconds.

edit: sorry I looked at the code and understood what you meant about 2.9 seconds, so yes, the text is "perfect"(but I think that nobody will want to use less than 10000ms since the frames will be skipped on other clients)

I'm just updating some info, but I recommend you to change this.kMinTimeout to 10000 and the warning message to explain that using a lower value will result in skipped frames on other clients and maybe blocking your account because sending so many requests to the discord api

toluschr commented 3 years ago

Perhaps, it could be < 2900 : error, < 10000 : warning. I don't want to restrict the settings too much.

pintoso commented 3 years ago

just an observation it's 2900 not 29000

image