search

tolwi / hassio-ecoflow-cloud

EcoFlow Cloud Integration for Home Assistant
369 stars 62 forks source link

Patch for Home Assistant Core 2024.5 #234

Closed unze closed 4 months ago

unze commented 4 months ago

Patch for Home Assistant Core 2024.5 https://github.com/tolwi/hassio-ecoflow-cloud/issues/232

sparkyws commented 4 months ago

Tested with...

Core 2024.5.1 Supervisor 2024.04.4 Operating System 12.2 Frontend 20240501.0.......Working Great

rhyddereh commented 4 months ago

Seems well enough tested, any chance at a merge?

angelbarrera92 commented 4 months ago

Seems well enough tested, any chance at a merge?

+1 here

KarinBerg commented 4 months ago

Works on Home Assistant Installation on Raspi 4 with: Core 2024.5.2 Supervisor 2024.05.1 Operating System 12.3 Frontend 20240501.1

KarinBerg commented 4 months ago

@unze Just wondering if we might need some if-else on the HA core version so that the integration is still working on older Home Assistant Core versions than 2024.5? or we might have to increase the "homeassistant" in https://github.com/tolwi/hassio-ecoflow-cloud/blob/main/hacs.json to "2024.5.0"

unze commented 4 months ago

i don't think we need that, as the function has been available since at least 2016 source: https://github.com/home-assistant/core/issues/4417