search

tolwi / hassio-ecoflow-cloud

EcoFlow Cloud Integration for Home Assistant
369 stars 62 forks source link

Typo in Powerstream discharge_level public API #309

Closed giovanne123 closed 3 weeks ago

giovanne123 commented 1 month ago

Powerstream public API

Is: number.powerstream_min_disharge_level

should: number.powerstream_min_discharge_level

Dev-Fabry commented 3 weeks ago

@giovanne123

Hi, What version were you using when you reported the problem?

With 1.1.0-pre6 and pre7 I see the correct sensor name (min_discharge_level).

giovanne123 commented 3 weeks ago

@Dev-Fabry , 1.1.0-pre6 - hm strange... (same for two Powerstreams I have added) maybe need to check again by updating to 1.1.0-pre7 and recreate the devices 🤔

But don't want to play too much at the moment because of #306

Dev-Fabry commented 3 weeks ago

The typo is still present in commented code but in Application API (I have created a Pull request) but I don't see other cases in working code (and my sensor has the correct name)

giovanne123 commented 3 weeks ago

Ok, thanks. Good that it is fine for you with public API. I will check with my next coming update...

Do you remember if you uninstalled the whole integration or only updated the integration release (and deleted, readded devices) when you updated from previous version without public API? (If I remember right, I updated only and readded devices)

Dev-Fabry commented 3 weeks ago

I definitely redownloaded the integration from scratch (but after having already switched to the Open API), because I wanted to make my own guide for ESPTemp and since I had already modified the code I redownloaded the integration to start from a clean version without my changes and then one step at a time try the changes (and report them in the guide).

And also when I switched from App API to Open API I redownloaded the integration because I was using the App API with 0.13.4

giovanne123 commented 3 weeks ago

Tested again with 1.1.0 and is fine.

Maybe on previous update from application API to public API I had some mixture of this entity.