tom-and-the-toothfairies / pathways

:older_woman: :hospital: :pill: :pill:
https://tomandthetoothfairies.info/
5 stars 0 forks source link

Report un-named PML construct #141

Closed houli closed 7 years ago

houli commented 7 years ago

Collect line numbers of unnamed constructs and their types during parse to report something like unnamed branch on line 32

c-brenn commented 7 years ago

As the resident compiler wizard, do you think this can all be done in the parse - or are you thinking we build an AST in parse then analyse it?

c-brenn commented 7 years ago

Need to ask him which constructs require names. His intention seemed to be that constructs have some unique identifier. Does the user have to specify these, or can they be generated?

Seems a bit mad that you would have to name your branches and selections (not very usable).

houli commented 7 years ago

Information is all there, just need to display it

laurmurclar commented 7 years ago

@c-brenn he wanted to use the identifiers so that it would be easy to target them for transformations. Seems like he wanted the user to have named them in the original upload and then generate new identifiers as the transformations created new constructs. If we were picking the constructs with a GUI rather than CLI, he might just allow us to ignore that feature.

c-brenn commented 7 years ago

definitely something we should discuss with him at the next meeting. As @laurmurclar said, the GUI could make this redundant. Could be a similar situation to our select and ontology feature. Where he's happy with a different approach as long as it achieves the same overall goal

ajenner commented 7 years ago

153 implements this, although further discussion RE: styling may be needed before this is closed

c-brenn commented 7 years ago

Seems it's just UI discussion left here. Closing this issue - we can move any discussion to #162