tom-and-the-toothfairies / pathways

:older_woman: :hospital: :pill: :pill:

https://tomandthetoothfairies.info/

5 stars 0 forks source link

Ability to Specify Delay in PML #174

Closed laurmurclar closed 7 years ago

laurmurclar commented 7 years ago

154

laurmurclar commented 7 years ago

So writing the elixir module is trickier than I anticipated. I think it's worth just adding the Erlang version for now to make sure it's included in this iteration. Can abstract out if I have time next week, but I definitely won't this weekend (my FYP demo is Monday)

laurmurclar commented 7 years ago

Can add some tests tonight but that's about all I'll have a chance to do this weekend.

c-brenn commented 7 years ago

Looks good. It's much simper now so I think having it all in Erlang is perfect. If we have to do anything more complicated with time (unlikely) it might be worth reconsidering the elixir module.

I have some free time today so I can finish off the tests and AST -> PML bit if you'd like.

laurmurclar commented 7 years ago

I'm happy I'll get the tests done but I'm not sure I'll have time to do the AST -> PML bit today. I can work on it tomorrow if you don't want to do it?

c-brenn commented 7 years ago

👍 work away on the tests so. The ast bit should only be a few small changes for me, I'll add that in after.

laurmurclar commented 7 years ago

Good job @c-brenn. Nice change with the floats 👍