Toggling night-mode resets to latest article

tom-anders / Easy_xkcd

An easy and simple open source xkcd reader

Apache License 2.0

165 stars 41 forks source link

Toggling night-mode resets to latest article #262

Closed evelikov closed 2 years ago

evelikov commented 3 years ago

This is my last night-mode bugreport I promise ;-)

When switching on/off the night-mode via the hamburger menu, the app resets to the last article. On the other hand changing it via settings works just fine. So it seems like we're preserving the number/index in the latter case but no the former.

tom-anders commented 3 years ago

Hmm I can't reproduce this one. Can you reproduce it 100% or does it only happen sometimes?

evelikov commented 3 years ago

It's 100% reproducible, although my original report is off - one needs to toggle night mode twice (off-on-off or on-off-on)

open app, go to random XKCD article
press the hamburger menu and toggle Night mode
you're still on the original article
press the hamburger menu and toggle Night mode
you're sent to the latest article

tom-anders commented 3 years ago

Ah yeah, now I can reproduce it as well. Will take a look.

tom-anders commented 2 years ago

Fixed in the beta (and also the upcoming 8.0 release)