search

tom-anders / Easy_xkcd

An easy and simple open source xkcd reader
Apache License 2.0
164 stars 41 forks source link

fix: use different inversion for night mode #332

Closed FineFindus closed 1 year ago

FineFindus commented 1 year ago

Closes #261, by using a different ColorMatrixColorFilter which uses the correct background color.

Example Screenshot of the comic with the same background color as the background

tom-anders commented 1 year ago

Thanks!

While I think this change looks nice and we should probably include it anyway, I think it does not actually fix #305: When enabling black/white inversions of images in night mode, there's an additional setting that controls whether images that contain color are inverted as well or not (sind oftentimes if looks weird). The issue in #305 seems to be that this setting does not work correctly - I played around a little bit with the setting and it looks like we indeed have a logic error somewhere.

If you want to, feel free to take a look, AppTheme.kt should still be a good start.

FineFindus commented 1 year ago

That's correct, I accidentally referenced the wrong commit, the correct one is #261.

Also, is there a way to quickly jump to a certain comic?

tom-anders commented 1 year ago

That's correct, I accidentally referenced the wrong commit, the correct one is #261.

Ah, that makes more sense :)

Also, is there a way to quickly jump to a certain comic?

Yeah I actually just added this in 0548a54 (The app used to have this feature already, but it got lost during the Kotlin rewrite.)